Remove virtual modifier from Calendar.CurrentEraValue
#104453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtual modifer from Calendar.CurrentEraValuevirtual modifier from Calendar.CurrentEraValue
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
tarekgh
approved these changes
Jul 4, 2024
The change is fine, but with regards to this explanation, there are zero overrides of this virtual method such that this base will always be the target of the invocation. As such, I'd expect dynamic PGO to optimize this well, such that CurrentEraValue would still be inlinable, just with an extra type check in front of it. |
stephentoub
approved these changes
Jul 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables inlining of the
CurrentEraValueproperty.MihuBot/runtime-utils#475 (comment)