Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix various asserts that were found by Antigen #104625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 11, 2024
Merged

Fix various asserts that were found by Antigen #104625

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
32b6e13
Ensure that we create a valid GT_IND node
tannergooding Jul 9, 2024
61d8289
Remove a bad assert in the associative morphs
tannergooding Jul 9, 2024
91e6f8f
Ensure that we check for GT_NULLCHECK when handling containment
tannergooding Jul 9, 2024
7976e1e
Fix a bad assert for x64
tannergooding Jul 9, 2024
6217f8a
Ensure we properly check for ConvertMaskToVector
tannergooding Jul 9, 2024
af07a4a
Fix the memory size used for some vbroadcast instructions in disasm a…
tannergooding Jul 9, 2024
ff45c4e
Ensure rewriting WithElement takes into account unsupported ISAs
tannergooding Jul 9, 2024
33ac032
Ensure we check FEATURE_HW_INTRINSICS
tannergooding Jul 9, 2024
04eb6ca
Apply formatting patch
tannergooding Jul 9, 2024
6e51285
Merge branch 'main' into antigen
tannergooding Jul 10, 2024
525fefa
Merge branch 'main' into antigen
tannergooding Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure we check FEATURE_HW_INTRINSICS
  • Loading branch information
@tannergooding
tannergooding committed Jul 9, 2024
commit 33ac032c02305e18bd3ce0f16ec06f426f684776
9 changes: 7 additions & 2 deletions src/coreclr/jit/gentree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,24 +1642,29 @@ struct GenTree

bool OperIsConvertMaskToVector() const
{
#if defined(FEATURE_HW_INTRINSICS)
#if defined(TARGET_XARCH)
return OperIsHWIntrinsic(NI_EVEX_ConvertMaskToVector);
#elif defined(TARGET_ARM64)
return OperIsHWIntrinsic(NI_Sve_ConvertMaskToVector);
#endif // !TARGET_XARCH && !TARGET_ARM64
#else
return false;
#endif
#endif // FEATURE_HW_INTRINSICS

}

bool OperIsConvertVectorToMask() const
{
#if defined(FEATURE_HW_INTRINSICS)
#if defined(TARGET_XARCH)
return OperIsHWIntrinsic(NI_EVEX_ConvertVectorToMask);
#elif defined(TARGET_ARM64)
return OperIsHWIntrinsic(NI_Sve_ConvertVectorToMask);
#endif // !TARGET_XARCH && !TARGET_ARM64
#else
return false;
#endif
#endif // FEATURE_HW_INTRINSICS
}

// This is here for cleaner GT_LONG #ifdefs.
Expand Down