Ensure that char doesn't box when using generic math
#104684
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Could you share an example where boxing was occurring? |
My mistake, the boxing was from a different bit of code in the sample I was looking at. This one is fine since its a |
|
Phew, ok, thanks :) |
This was referenced Jul 10, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs weren't explicitly defined, so they deferred down to the DIM which can box on some runtimes or scenarios.
I went and checked what other DIMs weren't explicitly redefined and found the newer
IUtf8SpanParsableAPIs weren't handled onchar,Int128/UInt128,BigInteger, orComplex. AdditionallyIUtf8SpanFormattablewasn't handled onBigInteger. I'll handle these in a different PR