Enable embedding install location options in apphost #104749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
src/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs
Outdated
Show resolved
Hide resolved
src/installer/managed/Microsoft.NET.HostModel/AppHost/AppHostExceptions.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 11, 2024
Open
vitek-karas
reviewed
Jul 12, 2024
src/installer/managed/Microsoft.NET.HostModel/AppHost/HostWriter.cs
Outdated
Show resolved
Hide resolved
|
|
||
| public AndConstraint<CommandResultAssertions> ExitWith(int expectedExitCode) | ||
| { | ||
| // Some Unix systems will have 8 bit exit codes |
There was a problem hiding this comment.
I believe this is a POSIX standard. No need for update, just FYI.
AaronRobinsonMSFT
approved these changes
Jul 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apphostfor .NET install search options. Format:<search_location_flags> /0 <app_relative_dotnet_path>apphostconditionally look at app-local, app-relative, environment variables, and global locations based on configured behaviourHostWriter.CreateAppHostPart of https://github.com/dotnet/designs/blob/main/proposed/apphost-embed-install-location.md.
There still needs to be a corresponding change on the SDK side to allow configuration via
AppHostDotNetSearchandAppHostRelativeDotNetproperties.cc @dotnet/appmodel