Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JIT: Avoid boxing ArgumentNullException.ThrowIfNull arguments in Tier-0 #104815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 15, 2024
Merged

JIT: Avoid boxing ArgumentNullException.ThrowIfNull arguments in Tier-0 #104815

merged 8 commits into from
Jul 15, 2024

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jul 12, 2024

Closes #104512

Example:

static void Test<T>(T a)
{
    ArgumentNullException.ThrowIfNull(a);
}

Current codegen for Test<int> in Tier0:

; Assembly listing for method Program:Test[int](int) (Tier0)
; Tier0 code
       push     rbp
       sub      rsp, 48
       lea      rbp, [rsp+0x30]
       xor      eax, eax
       mov      qword ptr [rbp-0x08], rax
       mov      dword ptr [rbp+0x10], ecx
       mov      rcx, 0x7FFD546561B0      ; System.Int32
       call     CORINFO_HELP_NEWSFAST
       mov      gword ptr [rbp-0x08], rax
       mov      rax, gword ptr [rbp-0x08]
       mov      ecx, dword ptr [rbp+0x10]
       mov      dword ptr [rax+0x08], ecx
       mov      rcx, gword ptr [rbp-0x08]
       mov      rdx, 0x203802095B0      ; 'a'
       call     [System.ArgumentNullException:ThrowIfNull(System.Object,System.String)]
       nop      
       add      rsp, 48
       pop      rbp
       ret

New codegen for Test<int> in Tier0:

; Assembly listing for method Program:Test[int](int) (Tier0)
; Tier0 code
       push     rbp
       sub      rsp, 16
       lea      rbp, [rsp+0x10]
       xor      eax, eax
       mov      qword ptr [rbp-0x08], rax
       mov      dword ptr [rbp+0x10], ecx
       add      rsp, 16
       pop      rbp
       ret

@AndyAyersMS I hope I didn't step on your foot since it's was assigned to you, it's just that it looked trivial and I decided to file a quick fix 🙂

In theory, we could solve this by a limitted version of inlining in tier0, but that is tricky and may regress startup time/lead to unnecessary type load events, etc.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 12, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS
AndyAyersMS approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we'd catch this in impBoxPatternMatch to avoid creating and then removing all the BOX IR, but that would require recognizing and intrinsic from its IL, which I guess could be clunky. This works too.

@AndyAyersMS
Copy link
Member

@AndyAyersMS I hope I didn't step on your foot since it's was assigned to you, it's just that it looked trivial and I decided to file a quick fix 🙂

No worries, I hadn't gotten around to this yet.

stephentoub
stephentoub reviewed Jul 12, 2024
View reviewed changes
@EgorBo
Copy link
Member Author

EgorBo commented Jul 12, 2024

I was thinking we'd catch this in impBoxPatternMatch to avoid creating and then removing all the BOX IR, but that would require recognizing and intrinsic from its IL, which I guess could be clunky. This works too.

The problem with that, - we'd need to do a redundant "resolveToken" call on call, yeah

This was referenced Jul 13, 2024
Open
Open
Closed
Closed
@MihuBot MihuBot mentioned this pull request Jul 13, 2024
Open
This was referenced Jul 13, 2024
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 14, 2024
Closed
@EgorBo
Copy link
Member Author

EgorBo commented Jul 14, 2024

@jakobbotsch @AndyAyersMS could you please review the Nullable<> part?

jakobbotsch
jakobbotsch reviewed Jul 14, 2024
View reviewed changes
@EgorBo @jakobbotsch
Update src/coreclr/jit/importercalls.cpp
ee83f6b 
Co-authored-by: Jakob Botsch Nielsen <[email protected]>
jakobbotsch
jakobbotsch reviewed Jul 14, 2024
View reviewed changes
jakobbotsch
jakobbotsch reviewed Jul 14, 2024
View reviewed changes
jakobbotsch
jakobbotsch reviewed Jul 15, 2024
View reviewed changes
@EgorBo EgorBo merged commit 5130683 into dotnet:main Jul 15, 2024
@EgorBo EgorBo deleted the fix-alloc-throwifnull branch July 15, 2024 14:38
@EgorBo EgorBo mentioned this pull request Jul 15, 2024
Closed
@jakobbotsch jakobbotsch mentioned this pull request Jul 16, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid boxing ArgumentNullException.ThrowIfNull arguments in Tier-0
4 participants
@EgorBo @AndyAyersMS @stephentoub @jakobbotsch