Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[browser] Turn BlazorCacheBootResources off by default when targeting .NET 9 #105235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Jul 22, 2024

With #103755 in place, custom cache is not needed anymore

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jul 22, 2024
@maraf maraf added this to the 9.0.0 milestone Jul 22, 2024
@maraf maraf self-assigned this Jul 22, 2024
@maraf maraf requested review from lewing and akoeplinger as code owners July 22, 2024 12:07
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf maraf requested review from pavelsavara and ilonatommy July 22, 2024 12:07
@pavelsavara
Copy link
Member

The cache code could be deleted (to reduce size & complexity).
Do we have good reason to keep it ?

@maraf
Copy link
Member Author

maraf commented Jul 22, 2024

The cache code could be deleted (to reduce size & complexity).
Do we have good reason to keep it ?

It's still useful when users disable fingerprinting. I would prefer leaving it place for 9 and discuss more about removing it for 10.

@maraf
Copy link
Member Author

maraf commented Jul 23, 2024

/ba-g previous run was green

@maraf maraf merged commit 705a548 into dotnet:main Jul 23, 2024
13 of 22 checks passed
@maraf maraf deleted the BrowserTurnOffCustomCache branch July 23, 2024 05:16
@maraf
Copy link
Member Author

maraf commented Jul 23, 2024

/backport to release/9.0-preview7

Copy link
Contributor

Started backporting to release/9.0-preview7: https://github.com/dotnet/runtime/actions/runs/10053151858

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants