Remove HelperMethodFrame from GetMulticastInvoke
#105584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move MethodTable acquisition from unmanaged to managed. This allows for converting instance FCalls to static.
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Jul 27, 2024
src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 27, 2024
src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 27, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Open
|
I see ~8% improvement in a delegate combine microbenchmark. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
MethodTableacquisition from unmanaged to managed.This allows for converting instance FCalls to static.