Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[LoongArch64] add DelayLoadHelperWithExistingIndirectionCell. #106304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

[LoongArch64] add DelayLoadHelperWithExistingIndirectionCell. #106304

merged 1 commit into from
Aug 13, 2024

Conversation

shushanhf
Copy link
Contributor

add DelayLoadHelperWithExistingIndirectionCell for LoongArch64.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024
@shushanhf shushanhf added arch-loongarch64 and removed community-contribution Indicates that the PR has been added by a community member labels Aug 13, 2024
@shushanhf
Copy link
Contributor Author

Hi, @jkotas Could you please review this PR?

BTW, when I add the arch-loongarch64 label, the dotnet-policy-service also added the community-contribution label at the same time and the community-contribution was removed.

This was referenced Aug 13, 2024
Open
Closed
Open
Open
@am11 am11 added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024
@am11
Copy link
Member

am11 commented Aug 13, 2024

BTW, when I add the arch-loongarch64 label, the dotnet-policy-service also added the community-contribution label at the same time and the community-contribution was removed.

After opening a PR, I give the bot a few seconds to set the labels before modifying labels manually. If we do it too fast, GH gets confused and removes the label added by the other user (bot).

@jkotas jkotas merged commit 506e749 into dotnet:main Aug 13, 2024
88 checks passed
@shushanhf shushanhf deleted the delayLoaderHelperIndirectionCell_LA branch August 14, 2024 00:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shushanhf @am11 @jkotas