Expose QUIC TLS details on QuicConnection. #106391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/ncl |
ManickaP
approved these changes
Aug 14, 2024
|
No-Merge until main becomes 10.0 |
wfurt
reviewed
Aug 14, 2024
| QUIC_CIPHER_SUITE.TLS_CHACHA20_POLY1305_SHA256 => TlsCipherSuite.TLS_CHACHA20_POLY1305_SHA256, | ||
| _ => default | ||
| }; | ||
| _negotiatedSslProtocol = info.TlsProtocolVersion switch |
There was a problem hiding this comment.
I'm wondering if we need to bother at all ... at least until there is Tls 1.4. If anythiung I would Debug.Assert here as reminder.
There was a problem hiding this comment.
we actually don't need to bother with either of the switches, the enum values are the same so we can cast directly.
I added assert for TLS 1.3 and unit test for cipher suites so that we notice if something changes.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #106368
Implements #70184.
Since TLS state is dropped by MsQuic after handshake since it is no longer needed, we need to retrieve TLS info during the CONNECTED event (as we do for negotiated ALPN)
cc: @wfurt