Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

AlexRadch
Copy link
Contributor

Close #48615

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Aug 17, 2024
@ghost
Copy link

ghost commented Aug 17, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Aug 17, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 17, 2024
@jkotas jkotas added area-System.Numerics and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 17, 2024
@tannergooding
Copy link
Member

CC. @JeremyKuhne, is WinForms ready to start using these types if exposed?

Adding them has only been blocked as that was the primary user and we didn't want to expose them without WinForms adopting them in the same release

Rgba.Tests
@JeremyKuhne
Copy link
Member

@tannergooding I'll be consuming this in WinForms WPF this cycle after it goes in.

@@ -0,0 +1,29 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

@tannergooding tannergooding Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was talking with @JeremyKuhne and his expectation matched mine, which was this was going to be part of the existing System.Numerics.Vectors package rather than a net new package.

Particularly for acceleration and support around float, there is likely to be a need for these (the color and existing Vector4/Matrix4x4/etc types) to be used in conjunction. The "downside" is that since System.Numerics.Vectors is in-box and frozen downlevel these new types would never be available on .NET Framework. However, that isn't a concern from the WinForms/WPF team (much as any of the other new graphics related vector/matrix/plane/etc APIs aren't available downlevel).

CC. @ericstj, just for additional confirmation there isn't something we're missing here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that sounds reasonable. Also this project was only targeting NetCoreAppCurrent and not a package - so not really a change in targeting - but we should avoid the new assembly. If folks decide later that there needs to be a polyfill then that could be created, but we don't proactively do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexRadch could you update the location to be in S.N.Vectors as indicated above? After that I can complete the review and ideally get this merged.

@tannergooding tannergooding added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 27, 2025
@jeffhandley jeffhandley added this to the 11.0.0 milestone Sep 2, 2025
Copy link
Contributor

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. new-api-needs-documentation no-recent-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Proposal: Add blittable Color to System.Numerics
8 participants