Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Speed up single-value SearchValues<string> candidate verification #108365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2025
Merged

Speed up single-value SearchValues<string> candidate verification #108365

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
241ed10
Speed up single-value SearchValues<string> candidate verification
MihaZupan Sep 29, 2024
865fc58
Improve comment, add extra assert
MihaZupan Mar 2, 2025
56a2a8a
Add path for Vector128
MihaZupan Mar 2, 2025
8b8ab2d
Add test stress for smaller vector sizes
MihaZupan Mar 2, 2025
70fd695
Print type of SearchValues<string> on fuzzer failure
MihaZupan Mar 2, 2025
fc28ebe
Expand SimpleIndexOfAnyValues test a bit more
MihaZupan Mar 3, 2025
45b6589
Merge branch 'main' into searchvalues-singleStringLengths4
stephentoub Mar 5, 2025
ad2be3a
Merge branch 'main' into searchvalues-singleStringLengths4
MihaZupan Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add path for Vector128
  • Loading branch information
@MihaZupan
MihaZupan committed Mar 2, 2025
commit 56a2a8a7f14ad366c3ddb3a2ff42826de1b1ee11
62 changes: 47 additions & 15 deletions ...ystem.Private.CoreLib/src/System/SearchValues/Strings/Helpers/StringSearchValuesHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,50 @@ public SingleValueState(string value, bool ignoreCase)
}
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public bool MatchesLength9To16_CaseSensitive(ref char matchStart)
{
Debug.Assert(Value.Length is >= 9 and <= 16);
Debug.Assert(ToUpperMask256 == default);

if (Vector256.IsHardwareAccelerated)
{
Vector256<ushort> input = Vector256.Create(
Vector128.LoadUnsafe(ref matchStart),
Vector128.LoadUnsafe(ref Unsafe.AddByteOffset(ref matchStart, SecondReadByteOffset)));

return input == Value256;
}
else
{
Vector128<ushort> different = Vector128.LoadUnsafe(ref matchStart) ^ Value256.GetLower();
different |= Vector128.LoadUnsafe(ref Unsafe.AddByteOffset(ref matchStart, SecondReadByteOffset)) ^ Value256.GetUpper();
return different == Vector128<ushort>.Zero;
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public bool MatchesLength9To16_CaseInsensitiveAscii(ref char matchStart)
{
Debug.Assert(Value.Length is >= 9 and <= 16);
Debug.Assert(ToUpperMask256 != default);

if (Vector256.IsHardwareAccelerated)
{
Vector256<ushort> input = Vector256.Create(
Vector128.LoadUnsafe(ref matchStart),
Vector128.LoadUnsafe(ref Unsafe.AddByteOffset(ref matchStart, SecondReadByteOffset)));

return (input & ToUpperMask256) == Value256;
}
else
{
Vector128<ushort> different = (Vector128.LoadUnsafe(ref matchStart) & ToUpperMask256.GetLower()) ^ Value256.GetLower();
different |= (Vector128.LoadUnsafe(ref Unsafe.AddByteOffset(ref matchStart, SecondReadByteOffset)) & ToUpperMask256.GetUpper()) ^ Value256.GetUpper();
return different == Vector128<ushort>.Zero;
}
}
}

public interface ICaseSensitivity
Expand Down Expand Up @@ -214,11 +258,7 @@ public static bool Equals<TValueLength>(ref char matchStart, ref readonly Single
}
else if (typeof(TValueLength) == typeof(ValueLength9To16))
{
Vector256<ushort> input = Vector256.Create(
Vector128.LoadUnsafe(ref matchStart),
Vector128.LoadUnsafe(ref Unsafe.AddByteOffset(ref matchStart, state.SecondReadByteOffset)));

return input == state.Value256;
return state.MatchesLength9To16_CaseSensitive(ref matchStart);
}
else if (typeof(TValueLength) == typeof(ValueLength4To8))
{
Expand Down Expand Up @@ -266,11 +306,7 @@ public static bool Equals<TValueLength>(ref char matchStart, ref readonly Single
}
else if (typeof(TValueLength) == typeof(ValueLength9To16))
{
Vector256<ushort> input = Vector256.Create(
Vector128.LoadUnsafe(ref matchStart),
Vector128.LoadUnsafe(ref Unsafe.AddByteOffset(ref matchStart, state.SecondReadByteOffset)));

return (input & state.ToUpperMask256) == state.Value256;
return state.MatchesLength9To16_CaseInsensitiveAscii(ref matchStart);
}
else if (typeof(TValueLength) == typeof(ValueLength4To8))
{
Expand Down Expand Up @@ -344,11 +380,7 @@ public static bool Equals<TValueLength>(ref char matchStart, ref readonly Single
}
else if (typeof(TValueLength) == typeof(ValueLength9To16))
{
Vector256<ushort> input = Vector256.Create(
Vector128.LoadUnsafe(ref matchStart),
Vector128.LoadUnsafe(ref Unsafe.AddByteOffset(ref matchStart, state.SecondReadByteOffset)));

return (input & state.ToUpperMask256) == state.Value256;
return state.MatchesLength9To16_CaseInsensitiveAscii(ref matchStart);
}
else if (typeof(TValueLength) == typeof(ValueLength4To8))
{
Expand Down