[release/9.0-staging] Fix Matrix4x4.CreateReflection when D is not zero #110162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC. @jeffhandley |
jeffhandley
approved these changes
Nov 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110057 to release/9.0-staging
/cc @tannergooding @hez2010
Customer Impact
#110050. Customers using
Matrix4x4.CreateReflectionmay see incorrect results on some hardware.Regression
#103527. The code was updated to be accelerated and had an edge case where all components were scaled by
-2instead of just theX, Y, and Zcomponents.Testing
An explicit test covering the scenario where the
Wcomponent was non-zero was added.Risk
Low. This is in an API that is primarily used in specialized scenarios.