Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/9.0-staging] Move ComWrappers AddRef to C/C++ #110815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 8, 2025
Merged

[release/9.0-staging] Move ComWrappers AddRef to C/C++ #110815

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ac2037
Move ComWrappers AddRef to C/C++
jkotas Dec 17, 2024
3680ccf
Apply suggestions from code review
jkotas Dec 17, 2024
ed8040c
Update src/coreclr/nativeaot/Runtime/HandleTableHelpers.cpp
jkotas Dec 17, 2024
290fda5
Update src/coreclr/nativeaot/Runtime/HandleTableHelpers.cpp
jkotas Dec 17, 2024
ec09f6a
Build break
jkotas Dec 17, 2024
71d73ec
Update src/coreclr/nativeaot/Runtime/HandleTableHelpers.cpp
jkotas Dec 17, 2024
008ab00
Apply suggestions from code review
jkotas Dec 17, 2024
ece65e4
Update src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtim…
jkotas Dec 17, 2024
1a30a88
Merge branch 'release/9.0-staging' into backport/pr-110762-to-release…
jeffschwMSFT Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/coreclr/nativeaot/Runtime/HandleTableHelpers.cpp
  • Loading branch information
@jkotas
jkotas authored and github-actions committed Dec 18, 2024
commit 71d73ec31f6805a1b2ced2af89a4e6bf5e053630
6 changes: 3 additions & 3 deletions src/coreclr/nativeaot/Runtime/HandleTableHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ static ManagedObjectWrapper* ToManagedObjectWrapper(void* dispatchPtr)
}

//
// AddRef is implemented in native code so that it can be invoked during a GC. This is important because Xaml invokes AddRef
// while holding a lock that it *also* holds while a GC is in progress. If AddRef was managed, we would have to synchronize
// with the GC before entering AddRef, which would deadlock with the other thread holding Xaml's lock.
// AddRef is implemented in native code so that it does not need to synchronize with the GC. This is important because Xaml
// invokes AddRef while holding a lock that it *also* holds while a GC is in progress. If AddRef was managed, we would have
// to synchronize with the GC before entering AddRef, which would deadlock with the other thread holding Xaml's lock.
//
static uint32_t __stdcall IUnknown_AddRef(void* pComThis)
{
Expand Down