[release/9.0-staging] fix TCP FastOpen compilation #111142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
antonfirsov
approved these changes
Jan 7, 2025
stephentoub
reviewed
Jan 7, 2025
| #if defined(__linux__) && !defined(TCP_FASTOPEN_CONNECT) | ||
| // fixup if compiled against old Kernel headers. | ||
| // Can be removed once we have at least 4.11 | ||
| #define TCP_FASTOPEN_CONNECT 30 |
There was a problem hiding this comment.
We're relying on getsockopt below failing when this is defined but not understood?
There was a problem hiding this comment.
yes. If the call fails e.g. not supported by given Kernel we would fall-back to traditional connect and data would be sent after handshake.
karelz
approved these changes
Jan 7, 2025
|
Impacts new 9.0 feature functionality for important customer, we should backport it. |
|
@carlossanlop we are waiting for shiproom approval. |
|
Approved by Tactics (@SteveMCarroll) via email on 1/14. Marking as Servicing-approved. I fear we missed the Feb release cutoff, so it will most likely be part of Mar release. |
|
/ba-g wasm failure is #103347 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110561 to release/9.0-staging
Fixes #110560
/cc @wfurt
Customer Impact
Requested by Oracle for ODP.NET. TCP FastOpen does not work on some Linux distros, causing functionality problem in their routing environments.
TCP FastOpen is a new feature in 9.0 and it does not work on all supported platforms.
The problem is caused by inconsistency of used kernel headers .NET builds against - some Docker images have old ones, causing the problem.
Regression
Not a regression. New 9.0 feature does not work on all platforms.
Testing
Tested on manual repro case.
There is no good way to automate tests of the functionality, because the negotiation depends on Kernel TCP cookie cache as well as there is no good way how to determine on receiving side if the data were sent with SYN packet or later.
Risk
Small. this is build problem and it gets glibc binaries on par with musl.