Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Downgrade MethodTables used in reflection invoke #111610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 6, 2025
Merged

Downgrade MethodTables used in reflection invoke #111610

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d75da5c
Update ReflectionInvokeMapNode.cs
MichalStrehovsky Jan 20, 2025
a1bbcf1
Update ReflectedFieldNode.cs
MichalStrehovsky Jan 20, 2025
b728c83
Normalize type instantiation in dependencies
MichalStrehovsky Jan 20, 2025
dc34018
Maybe we don't need #92994
MichalStrehovsky Jan 23, 2025
fff9a05
Beef up test
MichalStrehovsky Jan 23, 2025
4885566
Update ReflectionInvokeMapNode.cs
MichalStrehovsky Feb 6, 2025
cd4225d
Adjust tests
MichalStrehovsky Feb 7, 2025
30bab66
Is this still a saving?
MichalStrehovsky Feb 10, 2025
89c7c2e
Revert "Is this still a saving?"
MichalStrehovsky Mar 4, 2025
2bf75a0
Merge branch 'main' into MichalStrehovsky-patch-1
MichalStrehovsky Mar 4, 2025
c3cf2ba
Fix generic recursion
MichalStrehovsky Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update ReflectionInvokeMapNode.cs
  • Loading branch information
@MichalStrehovsky
MichalStrehovsky authored Jan 20, 2025
commit d75da5c84a5c667e2a433c19d05fb29897240e02
16 changes: 9 additions & 7 deletions ...eclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ReflectionInvokeMapNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ public static void AddDependenciesDueToReflectability(ref DependencyList depende
dependencies.Add(factory.MethodEntrypoint(invokeStub), "Reflection invoke");

var signature = method.Signature;
AddSignatureDependency(ref dependencies, factory, signature.ReturnType, "Reflection invoke");
AddSignatureDependency(ref dependencies, factory, signature.ReturnType, "Reflection invoke", isOut: true);
foreach (var parameterType in signature)
AddSignatureDependency(ref dependencies, factory, parameterType, "Reflection invoke");
AddSignatureDependency(ref dependencies, factory, parameterType, "Reflection invoke", isOut: false);
}

if (method.OwningType.IsValueType && !method.Signature.IsStatic)
Expand Down Expand Up @@ -96,10 +96,13 @@ public static void AddDependenciesDueToReflectability(ref DependencyList depende
ReflectionVirtualInvokeMapNode.GetVirtualInvokeMapDependencies(ref dependencies, factory, method);
}

internal static void AddSignatureDependency(ref DependencyList dependencies, NodeFactory factory, TypeDesc type, string reason)
internal static void AddSignatureDependency(ref DependencyList dependencies, NodeFactory factory, TypeDesc type, string reason, bool isOut)
{
if (type.IsByRef)
{
type = ((ParameterizedType)type).ParameterType;
isOut = true;
}

// Pointer runtime type handles can be created at runtime if necessary
while (type.IsPointer)
Expand All @@ -114,11 +117,10 @@ internal static void AddSignatureDependency(ref DependencyList dependencies, Nod
if (type.IsGCPointer)
return;

TypeDesc canonType = type.ConvertToCanonForm(CanonicalFormKind.Specific);
if (canonType.IsCanonicalSubtype(CanonicalFormKind.Any))
GenericTypesTemplateMap.GetTemplateTypeDependencies(ref dependencies, factory, canonType);
else
if (isOut)
dependencies.Add(factory.MaximallyConstructableType(type), reason);
else
dependencies.Add(factory.NecessaryTypeSymbol(type), reason);
}

public override ObjectData GetData(NodeFactory factory, bool relocsOnly = false)
Expand Down