Remove RequiresProcessIsolation from mcc tests
#111887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per dotnet#111406, `RequiresProcessIsolation` is not needed just because of `CMakeProjectReference`. The tests also have `CLRTestTargetUnsupported`, but all of them do, so I just moved it to the merged runner. (Note, mcc_i00 didn't have CLRTestTargetUnsupported to make it Windows only, but instead we had it in issues.targets as `needs triage`, so deleting that.) Before (CoreCLR checked, Microsoft DevBox): ``` Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary ============================================================================ 74.311 | 56 | 56 | 0 | 0 | JIT.jit64.jit64_2 ``` After: ``` Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary ============================================================================ 2.088 | 56 | 56 | 0 | 0 | JIT.jit64.jit64_2 ```
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jkoritzinsky
approved these changes
Jan 28, 2025
EgorBo
approved these changes
Jan 28, 2025
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Jan 28, 2025
* main: (31 commits) Fix linux-x86 build (dotnet#111861) Add FrozenDictionary specialization for integers / enums (dotnet#111886) [SRM] Refactor reading from streams. (dotnet#111323) Sign the DAC and DBI during the build process instead of in separate steps (dotnet#111416) Removing Entry2MethodDesc as it is unnecessary (dotnet#111756) Cross Product for Vector2 and Vector4 (dotnet#111265) Handle unicode in absolute URI path for combine. (dotnet#111710) Drop RequiresProcessIsolation on mcc tests (dotnet#111887) [main] Update dependencies from dotnet/roslyn (dotnet#111691) new trimmer feature System.TimeZoneInfo.Invariant (dotnet#111215) [browser] reduce msbuild memory footprint (dotnet#111751) Add debugging checks for stack overflow tests failure (dotnet#111867) Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2629821 (dotnet#111884) Bump main to preview2 (dotnet#111882) Avoid generic virtual dispatch for frozen collections alternate lookup (dotnet#108732) Bump main versioning to preview1 (dotnet#111880) Switch OneLoc to main (dotnet#111872) Improve docs on building ILVerify (dotnet#111851) Update Debian version to 13 (dotnet#111768) win32: add fallback to environment vars for system folder (dotnet#109673) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #111406,
RequiresProcessIsolationis not needed just because ofCMakeProjectReference. The tests also haveCLRTestTargetUnsupported, but all of them do, so I just moved it to the merged runner.(Note, mcc_i00 didn't have CLRTestTargetUnsupported to make it Windows only, but instead we had it in issues.targets as
needs triage, so deleting that.)Before (CoreCLR checked, Microsoft DevBox):
After:
Cc @dotnet/jit-contrib @jkoritzinsky