Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Random.Get{Hex}String #112162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2025
Merged

Add Random.Get{Hex}String #112162

merged 3 commits into from
Feb 21, 2025

Conversation

stephentoub
Copy link
Member

Fixes #111956

I chose not to adopt RandomNumberGenerator's much more complex GetHexString implementation and instead went with a simple wrapper for GetString. We can evaluate based on perf testing whether it'd be worthwhile to do so, but my expectation is the uses for GetHexString will involve shorter sequences where the perf differential will not huge.

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Feb 4, 2025
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

This was referenced Feb 5, 2025
Open
Open
Open
Open
@stephentoub stephentoub added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 5, 2025
@danmoseley danmoseley requested a review from Copilot February 14, 2025 03:47
Copilot
Copilot AI reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@stephentoub stephentoub requested a review from bartonjs February 19, 2025 15:58
@stephentoub stephentoub merged commit 24b8f3c into dotnet:main Feb 21, 2025
23 checks passed
@stephentoub stephentoub deleted the randomgetstring branch February 21, 2025 03:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
@ericstj
Copy link
Member

ericstj commented Apr 4, 2025

@stephentoub @bartonjs should we add a note to dotnet/core#9824?

@stephentoub
Copy link
Member Author

It's a small helper. We could.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@bartonjs bartonjs bartonjs approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Runtime new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Random.Get{Hex}String
3 participants
@stephentoub @ericstj @bartonjs