Remove CryptoConfigForwarder et al.
#112306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class does not seem to be necessary after the unification of the crypto assemblies.
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced Feb 8, 2025
Open
Closed
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/libraries/System.Security.Cryptography/src/System.Security.Cryptography.csproj: Language not supported
- src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptoConfig.Common.cs: Evaluated as low risk
- src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptoConfigForwarder.cs: Evaluated as low risk
- src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/KeyedHashAlgorithm.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptoConfig.cs:16
- [nitpick] The error message string 'CreateFromNameUnreferencedCodeMessage' could be clearer. Consider rephrasing to 'The default algorithm implementations might be removed. Use strong type references like 'RSA.Create()' instead.'
internal const string CreateFromNameUnreferencedCodeMessage = "The default algorithm implementations might be removed, use strong type references like 'RSA.Create()' instead.";
bartonjs
approved these changes
Mar 18, 2025
This was referenced Mar 19, 2025
vcsjones
approved these changes
Mar 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class does not seem to be necessary after the unification of the crypto assemblies. I also fixed a typo and did some minor clean-up.