Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JIT: Skip parameter register preferencing in OSR methods #112452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2025
Merged

JIT: Skip parameter register preferencing in OSR methods #112452

merged 3 commits into from
Feb 13, 2025

Conversation

jakobbotsch
Copy link
Member

Parameters are not passed in registers for OSR methods, so preferencing to certain registers based on this information does not make sense.

Follow-up to #110819

@jakobbotsch
JIT: Skip parameter register preferencing in OSR methods
fd353cf 
Parameters are not passed in registers for OSR methods, so preferencing
to certain registers based on this information does not make sense.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 11, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Feb 12, 2025
Open
Open
@jakobbotsch jakobbotsch marked this pull request as ready for review February 12, 2025 20:20
@Copilot Copilot AI review requested due to automatic review settings February 12, 2025 20:20
Copilot
Copilot AI reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • src/coreclr/jit/codegencommon.cpp: Language not supported
  • src/coreclr/jit/lower.cpp: Language not supported
  • src/coreclr/jit/lsra.cpp: Language not supported
  • src/coreclr/jit/lsrabuild.cpp: Language not supported

@build-analysis build-analysis bot mentioned this pull request Feb 12, 2025
Closed
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @kunalspathak

Minor diffs

kunalspathak
kunalspathak approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakobbotsch jakobbotsch merged commit e9a91f9 into dotnet:main Feb 13, 2025
109 of 111 checks passed
@jakobbotsch jakobbotsch deleted the osr-no-initial-reg-ref branch February 13, 2025 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobbotsch @kunalspathak