[release/8.0] Skip NegotiateStream_StreamToStream_Authentication_EmptyCredentials_Fails on WinSrv 2025 #112472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails on WinSrv 2025
|
Test-only change -> tell mode |
|
/ba-g WinHttpHandler failure is unrelated |
ericstj
reviewed
Feb 19, 2025
| @@ -192,6 +193,11 @@ public async Task NegotiateStream_StreamToStream_Authentication_EmptyCredentials | |||
| { | |||
| string targetName = "testTargetName"; | |||
|
|
|||
| if (PlatformDetection.IsWindowsServer2025) | |||
There was a problem hiding this comment.
This is a misnomer - it's checking any windows SKU newer than build 26100 -- so you've effectively turned this off these tests on all new windows machines. I noticed as this was failing in release branches where we haven't added testing for Server 2025.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual port of 92403f5 which did not made it in release branches.
Fixes #112312.
Customer Impact
None, Test-only change
Regression
No, new test failure occurred after adding new platform to test matrix.
Testing
CI run succeeds
Risk
Low, test-only change.