Remove thread pointer from AwareLock #112715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
kouvel
approved these changes
Feb 21, 2025
| #endif // !DACCESS_COMPILE | ||
|
|
||
| // the DAC needs to have this method available | ||
| PTR_Thread AwareLock::GetHoldingThread() |
There was a problem hiding this comment.
Nit: Would be good to replace the two remaining references to this function outside of the DAC, from threads.cpp in stress logs, to report the holding thread ID instead.
There was a problem hiding this comment.
Nevermind, these seem to only be under a macro that is not set, and only for diagnostic purposes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the thread pointer present in AwareLock since now it holds the thread id.
Verified with SOS SyncBlk command and with the VS debugger that the thread pointer still can be retrieved.
Follow-up work of #107168.