Relax encrypted cert requirement for Windows with Pkcs12Export tests #112741
Conversation
There was a problem hiding this comment.
PR Overview
This PR relaxes the PKCS#12 export unit test requirements by allowing unencrypted certificates on Windows, addressing issues present on older Windows versions.
- Updated the condition for counting certificates in Pkcs12CertBag to include unencrypted certificates when running on Windows.
Reviewed Changes
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/tests/X509Certificates/ExportTests.cs | Updated certificate counting logic for Windows in PKCS#12 export tests |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
|
That must have been a weird intermediate state in Windows 10. Since at least XP the behavior was two top-level collections: an encrypted one that contained certs, and an unencrypted one that contained shrouded keys. When I was experimenting with PFXes to justify writing a custom loader for macOS (.NET Core 3? 2? 5?), macOS wouldn't even read certs out of an unencrypted safe (or whatever the root things are really called) (or unshrouded keys, regardless of the state of the safe). Perhaps that's why Windows flipped back :) |
Older Windowses do not encrypt certificates in PKCS#12 exports, only keys. This change relaxes the counting of certificates in unit tests to include unencrypted certificates on Windows.
Contributes to #112738