Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JIT: Check ISA directly when printing JitDisasm #112828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2025
Merged

JIT: Check ISA directly when printing JitDisasm #112828

merged 2 commits into from
Feb 24, 2025

Conversation

jakobbotsch
Copy link
Member

compOpportunisticallyDependsOn does a JIT-EE call that can otherwise make the compilation miss when JitDisasm is enabled.

@jakobbotsch
JIT: Check ISA directly when printing JitDisasm
f5fbdf9 
`compOpportunisticallyDependsOn` does a JIT-EE call that can otherwise
make the compilation miss when `JitDisasm` is enabled.
@Copilot Copilot AI review requested due to automatic review settings February 23, 2025 20:02
Copilot
Copilot AI reviewed Feb 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 23, 2025
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @EgorBo

@jakobbotsch jakobbotsch requested a review from EgorBo February 23, 2025 22:01
This was referenced Feb 24, 2025
Open
Open
@jakobbotsch jakobbotsch merged commit 9b7b032 into dotnet:main Feb 24, 2025
109 of 112 checks passed
@jakobbotsch jakobbotsch deleted the jit-disasm-avoid-ee-call branch February 24, 2025 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@EgorBo EgorBo EgorBo approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobbotsch @EgorBo