-
Notifications
You must be signed in to change notification settings - Fork 5k
Pin SHAs for container images #113185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin SHAs for container images #113185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the container image references in the pipeline template by pinning them to specific SHA256 digests in order to prevent CI breakage.
- Each container image now includes a digest to ensure deterministic builds.
- All image references within the pipeline template have been updated with their corresponding pinned SHAs.
Reviewed Changes
File | Description |
---|---|
eng/pipelines/common/templates/pipeline-with-resources.yml | Updated container image references to include SHA256 digests for improved reliability during CI runs. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you.
@carlossanlop @jkoritzinsky -- Looks like this one can be merged. Need some help to push it forward. |
/ba-g "Known issue: dotnet/dnceng#5149" |
This reverts commit 0f45fea.
* Update dependencies from https://github.com/dotnet/arcade build 20250310.4 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25113.2 -> To Version 10.0.0-beta.25160.4 * Downgrade SDK and dotnet versions in global.json * Fix typo in global.json * Rolling back to 10.0.100-alpha.1.25077.2 * Pin SHAs for container images (#113185) * Bump MicrosoftDotNetApiCompatTaskVersion * Bump SdkVersionForWorkloadTesting individually instead * Revert MicrosoftDotNetApiCompatTaskVersion too * Update SdkVersionForWorkloadTesting value --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Eric StJohn <[email protected]> Co-authored-by: Rich Lander <[email protected]> Co-authored-by: Steve Pfister <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]>
We need to pre-pin these references to ensure that don't break CI.
Tool used: