Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/9.0-staging] [QUIC] Update MsQuic library version #113205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

[release/9.0-staging] [QUIC] Update MsQuic library version #113205

merged 1 commit into from
Mar 10, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 6, 2025 •
edited by ManickaP
Loading

Backport of #113159 to release/9.0-staging

Contributes to #113136

Customer Impact

Security in-depth change in msquic library - found internally.

We are updating just msquic dependency to 2.4.8 (we have reship msquic binaries on Windows -- on Linux we rely on external package published by msquic team directly). No unique changes to .NET code.

Note: We have done similar update in 2024/3 in 8.0 branch (9.0 hasn't had such change yet) - see commit 1207c32.

Regression

No

Testing

CI run - System.Net.Quic tests ran and passed - see #113205 (comment).

Risk

Low. Update of msquic library that is backward compatible (msquic team guaratnees it).
Also, customers on Linux get this version automatically with updates from their package managers.

@ManickaP ManickaP self-assigned this Mar 6, 2025
@ManickaP ManickaP added area-System.Net.Quic Servicing-consider Issue for next servicing release review and removed area-Infrastructure-libraries labels Mar 6, 2025
@ManickaP ManickaP requested review from GrabYourPitchforks and a team March 6, 2025 09:54
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

This was referenced Mar 6, 2025
Closed
Closed
Open
@ManickaP
Copy link
Member

ManickaP commented Mar 7, 2025

The tests ran and passed on Windows supporting MsQuic (i.e. TLS 1.3), e.g.: https://helixr1107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-113205-merge-fcc1694d55ed42c999/System.Net.Quic.Functional.Tests/1/console.8c9c2296.log?helixlogtype=result
The log shows 428 passing tests and names 2.4.8 as used MsQuic version.

C:\h\w\B4DE09B2\w\BF7F0A36\e>"C:\h\w\B4DE09B2\p\dotnet.exe" exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 139 of 152 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on [2 threads], stop on fail = off)
MsQuic supported and using 'msquic.dll 2.4.8.569855 (5ddc9bff4e82e910872fd239340e7970e3c768f8)'.
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
MsQuic Counters:
    CONN_CREATED 1605
    CONN_HANDSHAKE_FAIL 24
    CONN_APP_REJECT 8
    CONN_LOAD_REJECT 0

Unobserved exceptions of 0 different types: 

  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 428, Errors: 0, Failed: 0, Skipped: 1, Time: 134.580s
----- end Thu 03/06/2025 12:00:06.32 ----- exit code 0 ----------------------------------------------------------

Kusto Query used:

WorkItems
| where FriendlyName == "System.Net.Quic.Functional.Tests" and QueueName has "windows"
| join kind=inner Jobs on JobId
| where Branch has "113205"

@ManickaP
Copy link
Member

Approved over email.

@ManickaP ManickaP added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 10, 2025
@ManickaP
Copy link
Member

/ba-g aot SmokeTest failure is #103839

@ManickaP ManickaP merged commit 34ed4b3 into release/9.0-staging Mar 10, 2025
158 of 165 checks passed
@ManickaP ManickaP deleted the backport/pr-113159-to-release/9.0-staging branch March 10, 2025 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzikm rzikm rzikm approved these changes

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

Assignees

@ManickaP ManickaP

Labels
area-System.Net.Quic Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManickaP @rzikm