Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/8.0-staging] [QUIC] Update MsQuic library version #113206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

[release/8.0-staging] [QUIC] Update MsQuic library version #113206

merged 1 commit into from
Mar 10, 2025

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Mar 6, 2025 •
edited
Loading

Backport of #113159 from main (10.0) to release/8.0-staging

Contributes to #113136

Customer Impact

Security in-depth change in msquic library - found internally.

We are updating just msquic dependency to 2.4.8 (we have reship msquic binaries on Windows -- on Linux we rely on external package published by msquic team directly). No unique changes to .NET code.

Note: We have done similar update in 2024/3 - see commit 1207c32.

Regression

No

Testing

CI run - System.Net.Quic tests ran and passed, see #113206 (comment)

Risk

Low. Update of msquic library that is backward compatible (msquic team guaratnees it).
Also, customers on Linux get this version automatically with updates from their package managers.

@Copilot Copilot AI review requested due to automatic review settings March 6, 2025 09:52
Copilot
Copilot AI reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ManickaP ManickaP added the Servicing-consider Issue for next servicing release review label Mar 6, 2025
@ManickaP ManickaP requested review from GrabYourPitchforks and a team March 6, 2025 09:53
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP ManickaP changed the title [QUIC] Update MsQuic library version [release/8.0-staging] Update MsQuic library version Mar 6, 2025
@ManickaP ManickaP changed the title [release/8.0-staging] Update MsQuic library version [release/8.0-staging] [QUIC] Update MsQuic library version Mar 6, 2025
This was referenced Mar 6, 2025
Open
Open
Open
Open
Closed
@karelz karelz added this to the 8.0.x milestone Mar 6, 2025
rzikm
rzikm reviewed Mar 7, 2025
View reviewed changes
karelz
karelz approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@karelz karelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to update our dependencies to latest secure version.

@ManickaP
Copy link
Member Author

ManickaP commented Mar 7, 2025

The tests ran and passed on Windows supporting MsQuic (i.e. TLS 1.3), e.g.: https://helixr1107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-113206-merge-fd794bf5bdf8412c9b/System.Net.Quic.Functional.Tests/1/console.59eab2a3.log?helixlogtype=result
The log shows 353 passing tests and names 2.4.8 as used MsQuic version.

C:\h\w\ABFD0996\w\A3700914\e>"C:\h\w\ABFD0996\p\dotnet.exe" exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
MsQuic supported and using 'msquic.dll 2.4.8.569855 (5ddc9bff4e82e910872fd239340e7970e3c768f8)'.
  Discovered:  System.Net.Quic.Functional.Tests (found 120 of 133 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
    System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate(sendCertificate: True, useClientSelectionCallback: True) [SKIP]
      Client certificates are not supported on Windows Server 2022.
    System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate(sendCertificate: False, useClientSelectionCallback: True) [SKIP]
      Client certificates are not supported on Windows Server 2022.
    System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate(sendCertificate: True, useClientSelectionCallback: False) [SKIP]
      Client certificates are not supported on Windows Server 2022.
    System.Net.Quic.Tests.MsQuicTests.ConnectWithClientCertificate(sendCertificate: False, useClientSelectionCallback: False) [SKIP]
      Client certificates are not supported on Windows Server 2022.
    System.Net.Quic.Tests.MsQuicTests.UntrustedClientCertificateFails [SKIP]
      Client certificates are not supported on Windows Server 2022.
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 353, Errors: 0, Failed: 0, Skipped: 6, Time: 86.608s
----- end Fri 03/07/2025  9:51:15.84 ----- exit code 0 ----------------------------------------------------------

Kusto Query used:

WorkItems
| where FriendlyName == "System.Net.Quic.Functional.Tests" and QueueName has "windows"
| join kind=inner Jobs on JobId
| where Branch has "113206"

@build-analysis build-analysis bot mentioned this pull request Mar 7, 2025
Closed
@ManickaP ManickaP added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 10, 2025
@ManickaP
Copy link
Member Author

Approved over email.

@ManickaP
Copy link
Member Author

/ba-g infrastructure failure dotnet/dnceng#5144

@ManickaP ManickaP merged commit 1f87c0a into dotnet:release/8.0-staging Mar 10, 2025
183 of 189 checks passed
@ManickaP ManickaP deleted the 8.0-staging branch March 10, 2025 10:02
@ManickaP ManickaP mentioned this pull request Mar 19, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@karelz karelz karelz approved these changes

@rzikm rzikm rzikm approved these changes

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

Assignees

@ManickaP ManickaP

Labels
area-System.Net.Quic Servicing-approved Approved for servicing release
Projects
None yet
Milestone
8.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ManickaP @karelz @rzikm