[browser] Use OverrideHtmlAssetPlaceholders=true in browser template #113654
+95
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the browser wasm template to support HTML overrides during build and adjusts the fingerprint expectations for specific dotnet files. Key changes include:
- Updating the fingerprint flag for "dotnet.js" and the boot config file in WasmSdkBasedProjectProvider.cs.
- Introducing a new helper method GetBootConfigPath in ProjectProviderBase.cs to locate the fingerprinted boot configuration file.
Reviewed Changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mono/wasm/Wasm.Build.Tests/WasmSdkBasedProjectProvider.cs | Updated boolean flags to enable fingerprinting for dotnet.js and boot config file. |
| src/mono/wasm/Wasm.Build.Tests/ProjectProviderBase.cs | Refactored boot config file lookup by introducing GetBootConfigPath and updating its usage. |
Files not reviewed (10)
- src/mono/wasm/templates/templates/browser/browser.0.csproj: Language not supported
- src/mono/wasm/templates/templates/browser/wwwroot/index.html: Language not supported
- src/mono/wasm/testassets/BlazorBasicTestApp/App/BlazorBasicTestApp.csproj: Language not supported
- src/mono/wasm/testassets/BlazorBasicTestApp/App/wwwroot/index.html: Language not supported
- src/mono/wasm/testassets/WasmBasicTestApp/App/WasmBasicTestApp.csproj: Language not supported
- src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/index.html: Language not supported
- src/mono/wasm/testassets/WasmOnAspNetCore/BlazorClient/BlazorClient.csproj: Language not supported
- src/mono/wasm/testassets/WasmOnAspNetCore/BlazorClient/wwwroot/index.html: Language not supported
- src/mono/wasm/testassets/WasmOnAspNetCore/WasmBrowserClient/WasmBrowserClient.csproj: Language not supported
- src/mono/wasm/testassets/WasmOnAspNetCore/WasmBrowserClient/wwwroot/index.html: Language not supported
Comments suppressed due to low confidence (1)
src/mono/wasm/Wasm.Build.Tests/ProjectProviderBase.cs:512
- The GetBootConfigPath method does not return a value. Please add an appropriate 'return bootJsonPath;' statement before the method concludes.
}
Open
3 tasks
javiercn
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browserwasmtemplate to include placeholders and MSBuild settings to enable override of HTML files during build.dotnet.jsis fingerprinted.Contributes to dotnet/aspnetcore#60536