Use PME identity for DAC signing #113997
Merged
Use PME identity for DAC signing #113997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DAC signing configuration to use the PME identity by modifying certificate names, vault names, and azure subscriptions in the runtime-official pipeline.
- Updated certificate identifier to 'dac-dnceng-ssl-cert'.
- Modified vault names and azure subscriptions to reference PME identity credentials in two sections of the configuration.
Files not reviewed (1)
- eng/native/signing/auth.json: Language not supported
jkoritzinsky
approved these changes
Mar 28, 2025
9abe163 to
9d83c60
Compare
This was referenced Mar 28, 2025
9d83c60 to
133e839
Compare
jkoritzinsky
approved these changes
Mar 28, 2025
This was referenced Mar 29, 2025
|
This is pending an ESRP client update |
|
Tagging subscribers to this area: @hoyosjs |
133e839 to
3f391b4
Compare
jkoritzinsky
approved these changes
Apr 10, 2025
This was referenced Apr 11, 2025
|
/ba-g The only error is #114426, but it doesn't make sense to rebase since this path isn't tested in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.