ILLink : Fix and a couple tweaks #114215
Merged
ILLink : Fix and a couple tweaks #114215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbomer Please take a look |
sbomer
approved these changes
Apr 3, 2025
* Fix the SetupCompileBeforeAttribute's ctor parameters being out of sync. AdditionalArgs was changed to a `string[]` in one ctor but not the other. Updated a test to give coverage. * Put throw helpers inside of `#if NET`. We are still compiling `Mono.Linker.Tests.Cases.Expectations` against `netstandard2.0` and `net471` and this
0579e2d to
cd16386
Compare
|
I updated the PR to apply the same changes to |
This was referenced Apr 3, 2025
|
@sbomer I don't think the failures are related. Can you merge the PR? |
3 tasks
agocke
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the SetupCompileBeforeAttribute's ctor parameters being out of sync. AdditionalArgs was changed to a
string[]in one ctor but not the other. Updated a test to give coverage.Put throw helpers inside of
#if NET. We are still compilingMono.Linker.Tests.Cases.Expectationsagainstnetstandard2.0andnet471and this