Delete dead code #114419
Delete dead code #114419
Conversation
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
src/coreclr/vm/threads.cpp:7158
- The removal of FinalizerBase and consolidation into KickOff for both thread types is clear dead code deletion. Please ensure relevant tests cover the finalizer thread behavior to verify that exception handling and thread kickoff work as expected.
void ManagedThreadBase::KickOff(ADCallBackFcnType pTarget, LPVOID args)
src/coreclr/vm/excep.cpp:4541
- The call to DefaultCatchHandler has been modified to remove the 'isThreadBaseFilter' and 'sendAppDomainEvents' parameters. Ensure that this change aligns with the new function interface and that the expected exception event handling behavior is maintained.
DefaultCatchHandler(pParam->pExceptionInfo, NULL, useLastThrownObject, TRUE /* sendWindowsEventLog */);
src/coreclr/vm/ceeload.cpp:489
- The removal of the DACCESS_COMPILE guard around the initialization of m_pJitInlinerTrackingMap is observed. Confirm that this change is intentional and that it does not affect builds targeting DACCESS.
#if !defined(DACCESS_COMPILE)
src/coreclr/vm/appdomain.hpp:1148
- Changing the signature of OnUnhandledException from returning BOOL to void is a breaking change. Verify that all call sites have been updated to accommodate the new signature and that behavior remains consistent.
static void OnUnhandledException(OBJECTREF *pThrowable);
|
Tagging subscribers to this area: @mangod9 |
| enum UnhandledExceptionLocation | ||
| { | ||
| ProcessWideHandler = 0x000001, | ||
| ManagedThread = 0x000002, // Does not terminate the application. CLR swallows the unhandled exception. |
There was a problem hiding this comment.
ManagedThread and FinalizerThread were the only two actually used values from this enum, and the one place that they were used was dead code
|
|
||
| // ...so, continue search. i.e. let the exception go unhandled. | ||
| return EXCEPTION_CONTINUE_SEARCH; | ||
| } |
There was a problem hiding this comment.
This was always called with swallowing = true, so the rest of this method is dead code. The small piece from the above (ExceptionIsAlwaysSwallowed check) was folded into the caller.
|
/ba-g the test failure has been happening consistently on all runs since yesterday. #114426 |
No description provided.