Share common Uri redaction logic in Http #114483
Merged
+119
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/libraries/Microsoft.Extensions.Http/src/Microsoft.Extensions.Http.csproj: Language not supported
- src/libraries/System.Net.Http/src/System.Net.Http.csproj: Language not supported
- src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs:937
- [nitpick] Verify that the computed expectedUriTail correctly reflects the updated redaction behavior (i.e. excluding any URI fragments) and aligns with the new centralized logic in UriRedactionHelper.
string expectedUriTail = uriTail;
|
Tagging subscribers to this area: @dotnet/ncl |
ManickaP
approved these changes
Apr 10, 2025
antonfirsov
approved these changes
Apr 10, 2025
Co-authored-by: Anton Firszov <[email protected]>
This was referenced Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had duplicate logic between the client factory and http, and the
Redirectredaction was different (didn't account for user info & fragment).This makes all the places share the same logic.