Replace OptimizedInboxTextEncoder vectorization with SearchValues #114494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/libraries/System.Text.Encodings.Web/src/System.Text.Encodings.Web.csproj: Language not supported
- src/libraries/System.Text.Encodings.Web/tests/System.Text.Encodings.Web.Tests.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/libraries/System.Text.Encodings.Web/tests/AllowedAsciiCodePointsTests.cs:1
- Removal of AllowedAsciiCodePointsTests.cs may reduce test coverage for the fast path. Consider adding new tests to validate the SearchValues-based approach.
// Entire test file removed
src/libraries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/OptimizedInboxTextEncoder.cs:406
- Double-check that the combination of IndexOfAnyExcept with the char.IsAscii check correctly identifies the first disallowed character in all edge cases, especially when the span consists entirely of allowed characters.
if ((uint)asciiCharsSkipped >= (uint)data.Length || char.IsAscii(data[asciiCharsSkipped]))
...braries/System.Text.Encodings.Web/src/System/Text/Encodings/Web/OptimizedInboxTextEncoder.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-system-text-encodings-web |
|
@MihuBot benchmark System.Text.Json |
|
@MihuBot benchmark System.Text.Json -arm |
|
Just wondering, does the optimization using SearchValues will still work fine on previous .NET versions like .NET 8? |
tarekgh
approved these changes
Apr 10, 2025
I'd expect it to be very similar in this case since we're limiting usage to ASCII-only sets. I'll see what the numbers show for short inputs. |
This was referenced Apr 10, 2025
Open
|
Numbers for X64 System.Text.Json.Tests.Perf_Strings
ARM64 System.Text.Json.Tests.Perf_Strings
|
|
@EgorBot -mono --envvars MONO_ENV_OPTIONS:--interp --filter "Perf_Strings" |
This was referenced Apr 23, 2025
This was referenced Apr 23, 2025
Open
|
Some impressive improvements here for Wasm both interpreter and aot. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114437
I only replaced the existing ASCII-only fast path.
If we wanted to later, we could add a SearchValues implementation that handles the large character sets that STEW uses, in which case the .NET core implementation would just directly forward to SearchValues.