Add internal intrinsics for instance-based calli #114495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit |
There was a problem hiding this comment.
Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.
Files not reviewed (2)
- src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj: Language not supported
- src/coreclr/tools/aot/ILCompiler.ReadyToRun/ILCompiler.ReadyToRun.csproj: Language not supported
src/libraries/System.Runtime/tests/System.Reflection.Tests/MethodCommonTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 10, 2025
|
Wouldn't it be simpler to just write those stubs in IL instead of having to implement them in every VM? |
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
We would need to invent build infrastructure to merge this IL into CoreLib.... |
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
steveharter
commented
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
jkotas
reviewed
Apr 11, 2025
3 tasks
jkotas
reviewed
Apr 15, 2025
AaronRobinsonMSFT
approved these changes
Apr 15, 2025
This was referenced Apr 15, 2025
3 tasks
|
/ba-g infra timeout on building Libraries Test Run release coreclr linux_musl x64 Debug |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #112994. The next step in this process will use these intrinsics.
Adds support for both CoreClr JIT and R2R to modify the function pointer signature to add HasThis | ExplicitThis so specific function pointer signatures can be called on an instance method.
Local testing verified both:
The tests added here currently don't verify the intrinsics, but an earlier version did (see the first commit). Once the next step of hooking into reflection is done, these tests will cover the new intrinsics added here. In particular, the new tests address missing test cases of calling an instance-based method with non-primitive return types such as
Guid,DateTimeandTimeSpanthat would fail if reflection called these methods with function pointers \ Calli without HasThis | ExplicitThis.