Fix NRE in GenericLookupResult.Equals method #114624
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix-nre-in-GenericLookupResult
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
huoyaoyuan
reviewed
Apr 14, 2025
| @@ -81,7 +81,7 @@ public abstract class GenericLookupResult | |||
| public sealed override bool Equals(object obj) | |||
| { | |||
| GenericLookupResult other = obj as GenericLookupResult; | |||
| if (obj == null) | |||
| if (other == null) | |||
There was a problem hiding this comment.
if (obj is not GenericLookupResult other)
return false;for latest pattern.
MichalStrehovsky
approved these changes
Apr 14, 2025
|
@Alex4414 Out of curiosity: How did you spot this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo in the GenericLookupResult.Equals method. Instead of checking
otherfor null, the argumentobjis checked. If obj is not ofGenericLookupResulttype, then it will be NRE.