fix xharness #114746
Merged
fix xharness #114746
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update the XHarness test runner to use asynchronous return types for writing test results in response to fallout from a previous change.
- Updated WriteResultsToFile(XmlResultJargon) to return Task instead of a synchronous string.
- Updated WriteResultsToFile(TextWriter, XmlResultJargon) to return Task instead of void.
Comments suppressed due to low confidence (2)
src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs:55
- Although the method now returns a Task, it still performs synchronous file I/O. Consider using File.WriteAllTextAsync to fully support asynchronous operations.
File.WriteAllText(ResultsFileName, LastTestRun.GetTestResultOutput(_assemblyName));
src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs:72
- The synchronous write call may block the execution thread even though the method returns a Task. If the TextWriter supports asynchronous operations, consider using WriteLineAsync.
writer.WriteLine(lastTestResults);
akoeplinger
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix fallout of dotnet/xharness#1388