[cDAC] Implement ISOSDacImpl.GetAssemblyList #114800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ISOSDacImpl.GetAssemblyList API to support iterating assemblies within an AppDomain. Key changes include:
- Implementation of the GetAssemblyList method in SOSDacImpl.cs with appropriate argument checks, exception handling, and debug validation.
- Addition of new data types (e.g. LoaderAllocator, ArrayListBase, and related cdac_data specializations) and updates to the assembly and appdomain data models to support the new functionality.
- Updates to the ILoader interface and associated loaders in the DataContractReader.Contracts to enumerate assemblies based on various iteration flags.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdacreader/src/Legacy/SOSDacImpl.cs | Implements the GetAssemblyList API with error checks and debug validation against legacy implementations. |
| src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Data/LoaderAllocator.cs | Introduces LoaderAllocator data type for tracking loader allocations. |
| src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Assembly.cs | Extends the Assembly data type with new fields (Module, Error, NotifyFlags, Level) to support assembly status. |
| src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ArrayListBase.cs | Provides implementation for ArrayListBase and its block elements using modern collection initialization. |
| src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Data/AppDomain.cs | Adds DomainAssemblyList field for improved assembly enumeration in AppDomains. |
| src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs | Updates ILoader contract with GetAssemblies and IsAssemblyLoaded methods. |
| Other coreclr and datadescriptor files | Updates to cdac_data and constant definitions to support the new APIs. |
.../managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @tommcdon |
max-charlamb
commented
Apr 17, 2025
65a2ec4 to
74cc1a4
Compare
This was referenced Apr 18, 2025
Open
mikem8361
approved these changes
Apr 22, 2025
mikem8361
approved these changes
Apr 25, 2025
d846425 to
17a623f
Compare
This was referenced Apr 29, 2025
This was referenced Apr 29, 2025
mikem8361
approved these changes
May 1, 2025
This reverts commit 3e22096.
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Assembly.cs
Outdated
Show resolved
Hide resolved
| @@ -15,10 +15,32 @@ readonly struct ModuleHandle | |||
| [Flags] | |||
| enum ModuleFlags | |||
| { | |||
| Tenured = 0x00000001, // Set once we know for sure the Module will not be freed until the appdomain itself exits | |||
There was a problem hiding this comment.
There needs to be a detail in the versioned portion of the contract indicating which module flags are actually handled by that specific version of the contract. I want to be able to know which magic constants are meaningful, and the current document does not explain. (This becomes relevant since we may renumber the enum in the runtime, but we won't be able to renumber the enum in the contract interface.)
There was a problem hiding this comment.
Created ModuleFlags_1 which represent the runtime implementation of Module::Flags and a function to map ModuleFlags_1 to ModuleFlags.
davidwrighton
approved these changes
May 2, 2025
688baab to
173d72c
Compare
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 5, 2025
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g Known issue #115070 and unrelated failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of work for #114336, the cDAC now supports iterating Assemblies in an AppDomain so this API falls out nicely.
It is also used as part of
!dumpdomainand is relatively easy to test.Given we already have a
ModuleHandleinILoader, I wanted to keep using that even if we have to iterate assemblies. On further thought, it appears an assembly can exist without a module. Therefore, I'm wondering if it would be reasonable to convert to using anAssemblyHandle. Can a module exist without an assembly?Edit: Discussed with @davidwrighton and decided that a
Moduleshould always exist for all relevantAssemblyinstances. Therefore, we can use theModuleHandleto represent anAssembly.