Skip zip test on wasm #114801
Merged
Skip zip test on wasm #114801
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The purpose of the PR is to address test failures on the WASM platform by skipping execution of specific tests under that environment.
- Added the SkipOnPlatform attribute to tests failing on Browser/WASM in the ZipArchive and ZipFile test suites.
- Updated three test files to conditionally disable execution on the Browser platform.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.IO.Compression/tests/ZipArchive/zip_InvalidParametersAndStrangeFiles.cs | Added SkipOnPlatform attribute to skip a test on Browser. |
| src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Extract.cs | Added SkipOnPlatform attribute to the ZipFile class to disable tests on Browser. |
| src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Extract.Stream.cs | Added SkipOnPlatform attribute to the ZipFile_Extract_Stream class to skip tests on Browser. |
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
lewing
approved these changes
Apr 17, 2025
|
/ba-g Fast merge to unblock CIs |
This was referenced Apr 17, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lewing