[crossgen2] Rename TryGetReadyToRunHeader to TryGetCompositeReadyToRunHeader #114886
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkotas
commented
Apr 22, 2025
- Delete local definition that is no longer needed
- Rename method to make its name match what it actually does
There was a problem hiding this comment.
Pull Request Overview
This PR performs a minor cleanup to improve consistency in handling ReadyToRun images. It renames methods to better reflect their composite detection functionality and removes an obsolete local constant to simplify the code.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/tools/aot/crossgen2/Program.cs | Updated the ReadyToRun header retrieval method to use the composite variant. |
| src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs | Modified ReadyToRun-related method calls to align with the composite image handling. |
| src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/PEReaderExtensions.cs | Renamed the method and updated the documentation to indicate composite ReadyToRun image support. |
| src/coreclr/tools/Common/TypeSystem/Ecma/EcmaMethod.cs | Removed the unnecessary local constant in favor of directly using MethodImplAttributes.AggressiveOptimization. |
Open
3 tasks
steveisok
approved these changes
Apr 22, 2025
|
/ba-g infrastructure timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.