[WinHTTP] Fix ContentDisposition test on FW #114892
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ContentDisposition test on .NET Framework by handling platform-specific differences in the expected file name format.
- Updates the expected file name to include quotes on .NET Framework
- Uses preprocessor directives to differentiate behavior between .NET Framework and other targets
| @@ -646,7 +646,11 @@ await LoopbackServer.CreateClientAndServerAsync(async uri => | |||
| Assert.Contains("close", resp.Headers.Connection); | |||
| Assert.True(resp.Headers.ConnectionClose.GetValueOrDefault()); | |||
| Assert.Equal("attachment", resp.Content.Headers.ContentDisposition.DispositionType); | |||
| #if NETFRAMEWORK | |||
There was a problem hiding this comment.
Consider adding a comment explaining why the expected FileName value includes quotes on .NET Framework. This will help future maintainers understand the platform-specific behavior.
Copilot uses AI. Check for mistakes.
|
Tagging subscribers to this area: @dotnet/ncl |
MihaZupan
approved these changes
Apr 22, 2025
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114790