Refactor SLH-DSA tests #114981
Merged
Refactor SLH-DSA tests #114981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SLH-DSA tests to simplify the inheritance hierarchy and reduce duplicate test execution. Key changes include reorganizing tests into separate classes (e.g. SlhDsaContractTests, SlhDsaFactoryTests, SlhDsaOpenSslTests), removing redundant or legacy test base classes, and updating test code style with modern collection initialization syntax.
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/tests/SlhDsaOpenSslTests.cs | Introduces tests for OpenSSL-specific SLH-DSA functionality using modern collection initialization. |
| src/libraries/System.Security.Cryptography/tests/SlhDsaOpenSslConstructionTests.Unix.cs | Refactors the construction tests into a static class with static test methods. |
| src/libraries/System.Security.Cryptography/tests/SlhDsaOpenSslConstructionTests.NotSupported.cs | Refactors the unsupported platform tests and removes unused inheritance. |
| src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/*.cs | Removes legacy test base classes and reorganizes tests into dedicated files (e.g., SlhDsaContractTests, SlhDsaFactoryTests), while integrating updated API validations and buffer checks. |
Files not reviewed (2)
- src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj: Language not supported
- src/libraries/System.Security.Cryptography/tests/System.Security.Cryptography.Tests.csproj: Language not supported
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced Apr 24, 2025
Open
bartonjs
reviewed
Apr 24, 2025
...n/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaAlgorithmTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...on/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaContractTests.cs
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...on/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaContractTests.cs
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...mon/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaFactoryTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...mon/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaFactoryTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...mon/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaFactoryTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...mon/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaFactoryTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...on/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaContractTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
.../Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestData.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...mmon/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestHelpers.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...ies/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...ies/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
...ies/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
src/libraries/System.Security.Cryptography/tests/System.Security.Cryptography.Tests.csproj
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Apr 24, 2025
bartonjs
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old inheritance hierarchy was too complicated and test were running multiple times for no reason. This PR refactors the test to have: