Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use SDK ILLink analyzer for OOBs for downlevel TFMs #114983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use SDK ILLink analyzer for OOBs for downlevel TFMs #114983

wants to merge 4 commits into from
+41 −10

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Apr 24, 2025

Don't use live ILLink analyzer for OOBs when targeting downlevel TFMs. Should help catch issues like #114307.

@Copilot Copilot AI review requested due to automatic review settings April 24, 2025 00:35
Copilot
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • eng/liveILLink.targets: Language not supported
  • src/libraries/Directory.Build.props: Language not supported
  • src/libraries/Directory.Build.targets: Language not supported

@sbomer sbomer mentioned this pull request Apr 24, 2025
Open
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

ViktorHofer
ViktorHofer reviewed Apr 24, 2025
View reviewed changes
This was referenced Apr 24, 2025
Open
Open
Open
Open
sbomer added 3 commits April 24, 2025 17:20
@sbomer
PR feedback
563dfc5 
- Use IsTargetFrameworkCompatible
- Move EnableAOTAnalyzer to targets
- Rename ExplicitlyImportCustomILLinkTargets to
  ImportCustomILLinkTargets and infer value
@sbomer
Build logic fixes
8c420d0 
- Fix typo
- Use IsTargetFrameworkCompatible
- Import illink.targets only for netcoreapp
  To prevent netfx TFMs from attempting to use
  ILLink tasks that aren't available when targeting
  netfx.
- Only use live ILLIink for current TFM
@sbomer
Update suppressions in STJ
63aa3c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@sbomer sbomer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbomer @ViktorHofer