[browser] Clean up Wasm.Build.Tests #114993
Merged
+11
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the Wasm.Build.Tests by removing obsolete tests and parameters now that OverrideHtmlAssetPlaceholders is enabled by default for both wasm and blazor apps.
- Removed the explicit OverrideHtmlAssetPlaceholders parameter in tests and updated AssertAppBundle values in PreloadingTests.
- Deleted the FingerprintingTests file and the test for OverrideHtmlAssetPlaceholders in Blazor MiscTests.
- Updated project and job list files to reflect the consolidated testing strategy.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/wasm/Wasm.Build.Tests/PreloadingTests.cs | Removed obsolete MSBuild flag and updated AssertAppBundle parameter. |
| src/mono/wasm/Wasm.Build.Tests/FingerprintingTests.cs | Entire file removed as the behavior is now covered elsewhere. |
| src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests.cs | Removed outdated test for OverrideHtmlAssetPlaceholders from Blazor tests. |
| src/mono/wasm/Wasm.Build.Tests/Blazor/AppsettingsTests.cs | Eliminated the extra property for OverrideHtmlAssetPlaceholders. |
| eng/testing/scenarios/BuildWasmAppsJobsList.txt | Removed the FingerprintingTests entry from the job list. |
Comments suppressed due to low confidence (3)
src/mono/wasm/Wasm.Build.Tests/FingerprintingTests.cs:1
- The removal of the FingerprintingTests file may reduce test coverage for fingerprinting behavior. Ensure that the scenarios previously covered in this file are adequately tested in the remaining test suites.
// Licensed to the .NET Foundation under one or more agreements.
src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests.cs:98
- The removal of the TestOverrideHtmlAssetPlaceholders in Blazor tests may leave a gap in verifying the behavior of OverrideHtmlAssetPlaceholders. Verify that this scenario is covered elsewhere in the test suite.
public async Task TestOverrideHtmlAssetPlaceholders() { ... }
eng/testing/scenarios/BuildWasmAppsJobsList.txt:48
- Removing the FingerprintingTests job from the testing scenarios can reduce automated verification of fingerprinting behavior. Confirm that all important fingerprinting scenarios are still being exercised by other tests.
Wasm.Build.Tests.FingerprintingTests
ilonatommy
approved these changes
Apr 25, 2025
|
checking if #114548 fixed the failures |
…fingerprinted set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OverrideHtmlAssetPlaceholdersis now default for both wasm & blazor apps