Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/9.0-staging] Don't expose TrustedCertificatesDirectory() and StartNewTlsSessionContext() to NetFx #114995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/9.0-staging
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 24, 2025

Backport of #113963 to release/9.0-staging

/cc @steveharter

v8 backport: #115008

Customer Impact

  • Customer reported
  • Found internally

Two recently added members are now removed from the NetStandard package so that a project targeting NetStandard will get a compile error if they try to use the members instead of a MissingMethodException if the members are called when running under .NET Framework.

Regression

  • Yes
  • No

Testing

Verified the NetStandard2.0 package does not contain:

  • LdapSessionOptions::get_TrustedCertificatesDirectory()
  • LdapSessionOptions::set_TrustedCertificatesDirectory()
  • LdapSessionOptions::StartNewTlsSessionContext()

Risk

Low. The method does not exist in the .NET Framework implementation, so we don't expose it in NetStandard.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

@steveharter steveharter self-assigned this Apr 24, 2025
@steveharter steveharter requested review from artl93 and ericstj April 24, 2025 20:14
@steveharter steveharter added Servicing-consider Issue for next servicing release review and removed new-api-needs-documentation labels Apr 24, 2025
@steveharter steveharter added this to the 9.0.x milestone Apr 24, 2025
@rbhanda rbhanda modified the milestones: 9.0.x, 9.0.6 Apr 29, 2025
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 29, 2025
@vseanreesermsft vseanreesermsft added Servicing-consider Issue for next servicing release review and removed Servicing-consider Issue for next servicing release review labels May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants