Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[browser] runtimeConfig via boot config #115113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[browser] runtimeConfig via boot config #115113

wants to merge 1 commit into from
+286 −89

Conversation

pavelsavara
Copy link
Member

  • extend BootJsonData with runtimeConfig which matches just the runtimeOptions.configProperties part of *.runtimeconfig.json
  • load RuntimeConfigJsonPath in GenerateWasmBootJson and in WasmAppBuilder
  • drop RuntimeConfigParserTask from browser and move it to WASI msbuild
  • convert from json to char** in startup.ts
  • library mode initialize_runtime() out of scope
export const config = /*json-start*/{
  "mainAssemblyName": "Wasm.Browser.Sample.dll",
  "debugLevel": -1,
  "globalizationMode": "sharded",
  ...
  "runtimeConfig": {
    "runtimeOptions": {
      "configProperties": {
        "System.Net.Http.WasmEnableStreamingResponse": true,
        "Microsoft.Extensions.DependencyInjection.VerifyOpenGenericServiceTrimmability": true,
        ...
      }
    }
  }
}/*json-end*/;

Fixes #97449
Fixes #112442

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Apr 28, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Apr 28, 2025
@pavelsavara pavelsavara self-assigned this Apr 28, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara force-pushed the browser_runtimeConfig branch from a6a243d to b9bdea8 Compare April 28, 2025 16:29
This was referenced Apr 28, 2025
Open
Open
Open
Open
Open
@maraf maraf changed the title [browser] runtimeConfig via dotnet.boot.js [browser] runtimeConfig via boot config Apr 29, 2025
@pavelsavara pavelsavara force-pushed the browser_runtimeConfig branch from feabc48 to ac0e359 Compare May 6, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf Awaiting requested review from maraf maraf will be requested when the pull request is marked ready for review maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger will be requested when the pull request is marked ready for review akoeplinger is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy will be requested when the pull request is marked ready for review ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
1 participant
@pavelsavara