[cDAC] Implement IXCLRDataProcess.EnumMethodInstancesByAddress #115131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
This was referenced Apr 29, 2025
Open
a2601ce to
fc70764
Compare
| MethodDescFlags_1.MethodDescFlags.ClassificationMask | | ||
| MethodDescFlags_1.MethodDescFlags.HasNonVtableSlot | | ||
| MethodDescFlags_1.MethodDescFlags.HasMethodImpl | | ||
| MethodDescFlags_1.MethodDescFlags.HasNativeCodeSlot)); |
There was a problem hiding this comment.
This is out of date. The merge of the async logic has added a new flag.
There was a problem hiding this comment.
In general, you need to review the updates done by async to see if there are any other changes we need, and if we need to bump a contract version.
fc70764 to
ff70d24
Compare
6a947f1 to
533ac30
Compare
added 8 commits
May 6, 2025 11:27
added 13 commits
May 6, 2025 11:27
04ea4de to
dc87671
Compare
added 2 commits
May 6, 2025 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #114336
Implements:
IXCLRDataProcess.StartEnumMethodInstancesByAddressIXCLRDataProcess.EnumMethodInstancesByAddressIXCLRDataProcess.EndEnumMethodInstancesByAddressIXCLRDataMethodInstance.GetTokenAndScopeIXCLRDataMethodInstance.GetRepresentativeEntryAddressThese final two APIs allow me to test that enumerating the method instances return the correct COM object/data.
In order to implement these APIs, the following contracts were updated:
IEnumerable<TargetPointer> GetAvailableTypeParams(ModuleHandle handle)IEnumerable<TargetPointer> GetInstantiatedMethods(ModuleHandle handle)TargetPointer GetMethodDescForSlot(TypeHandle methodTable, ushort slot)TargetPointer MapTargetBackToMethodDesc(TargetCodePointer codePointer)and the following data types were added:
EETypeHashTableto read available type parameters on a moduleInstMethodHashTableto read instantiated methods in a moduleECHashto parse the FCall hash table and map entrypoints to FCall method descs.Open Questions
MethodDesc::s_ClassificationSizeTableto the DAC Enum memory regions so it is present in all mini dumps?