Fix regex description emitted by generator for switched branches #115136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emitter is mutating the regex tree, under the assumption that no one subsequently looks at the tree... but the XML comment generator does. Make sure the mutations are undone.
There was a problem hiding this comment.
Pull Request Overview
A concise update to fix the regex description emitted by the generator for switched branches by ensuring that temporary mutations to the regex tree are undone properly.
- Updated the GeneratedCodeAttribute version placeholder in test output.
- Modified the emitter logic to correctly slice off the first character for multi and concatenation nodes, including restoring the original state after mutation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/RegexGeneratorOutputTests.cs | Updated test output to use a version placeholder and add new test cases verifying the generator’s output. |
| src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs | Modified the code emission for switched branches to correctly slice off the first character and safely restore mutated nodes. |
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/RegexGeneratorOutputTests.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emitter is mutating the regex tree, under the assumption that no one subsequently looks at the tree... but the XML comment generator does. Make sure the mutations are undone.
Fixes #114889