JIT: Decrease Gauss-Seidel stop residual #115150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR decreases the Gauss-Seidel stop residual threshold to achieve tighter convergence in the solver.
- Reduces the stop residual constant from 0.002 to 0.001.
- Addresses issue Arm64: !"Inconsistent profile data" Remove empty try-catch-fault 3 #115122 by modifying the termination condition in the solver.
Comments suppressed due to low confidence (1)
src/coreclr/jit/fgprofilesynthesis.cpp:1189
- Please verify that the adjustment to the stop residual threshold is sufficiently covered by tests to ensure that the solver's convergence behavior remains stable and performs as expected. Consider adding or updating tests if necessary.
weight_t const stopRelResidual = 0.001;
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
/azp run Antigen |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Antigen didn't hit any profile inconsistency asserts. Thanks! |
AndyAyersMS
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115122 (comment).