Fix ML-KEM test to use PBES1+3DES #115160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ML-KEM test to address a failing scenario on Windows by switching the test PFX data and password handling.
- Introduces a new constant PfxPassword and an embedded Base64 PFX string.
- Updates all instances of the password argument to use the new constant.
src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxTests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxTests.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
reviewed
Apr 29, 2025
src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxTests.cs
Show resolved
Hide resolved
bartonjs
approved these changes
Apr 29, 2025
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Apr 30, 2025
It got introduced with dotnet#115160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another instance of a test failing in Windows 10 SP0 and libraries tests don't run that, by default.
All of the ML-KEM test PFX certificates are encoded with PBES2. This changes the "Not supported" scenario of the test to use a PBES1 / 3DES+SHA1 encoded PFX.
Contributes to #115156 (not marking as closing so Build Analysis sees it for pipelines running before this change)