Fix regression caused by overload resolution. #115164
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-buffers |
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a regression caused by overload resolution by updating the internal API calls.
- Updated the call in SpanHelpers.ByteMemOps.cs to use Buffer.MemmoveInternal.
- Renamed the internal method in Buffer.cs from Memmove to MemmoveInternal to resolve overload ambiguity.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/SpanHelpers.ByteMemOps.cs | Updated the method call to use the newly renamed internal method. |
| src/libraries/System.Private.CoreLib/src/System/Buffer.cs | Renamed the method to MemmoveInternal to clear up overload resolution issues. |
Comments suppressed due to low confidence (1)
src/libraries/System.Private.CoreLib/src/System/Buffer.cs:130
- Verify that renaming the internal method from 'Memmove' to 'MemmoveInternal' clarifies its intended use without breaking internal dependencies.
internal static unsafe void MemmoveInternal(ref byte dest, ref byte src, nuint len)
src/libraries/System.Private.CoreLib/src/System/SpanHelpers.ByteMemOps.cs
Show resolved
Hide resolved
|
/cc @jkotas |
jkotas
reviewed
Apr 29, 2025
This was referenced May 6, 2025
[Perf] Linux/x64: 14 Improvements on 4/30/2025 2:49:21 PM +00:00
dotnet/perf-autofiling-issues#55026
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #113715
Fixes #114696
See #114696 (comment)
Thanks @tfenise