Add timeout to Fuzzlyn reductions #115189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a timeout parameter to the Fuzzlyn reduction process in an effort to prevent excessively long runs.
- Updated run_command in jitutil.py to support an optional timeout with a threading.Timer
- Modified fuzzlyn_run.py to pass a 25-minute timeout when reducing examples
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/scripts/jitutil.py | Added _timeout parameter and timer logic to terminate long-running commands |
| src/coreclr/scripts/fuzzlyn_run.py | Updated run_command calls to include the new timeout parameter and improved messaging when reduction fails |
| decode_and_print(command_stderr) | ||
| timer = None | ||
| if _timeout is not None: | ||
| def try_kill(): |
There was a problem hiding this comment.
Consider catching specific exceptions instead of using a bare 'except:' in the try_kill function to avoid masking potential errors.
Member
Author
|
/ba-g Build analysis is stuck and this is a change in a pipeline script |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a 25 minute timeout for Fuzzlyn reduction in an attempt to fix #115171